Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/make



On Sat, Jul 04, 2020 at 03:44:07PM +0000, Roland Illig wrote:
> Module Name:	src
> Committed By:	rillig
> Date:		Sat Jul  4 15:44:07 UTC 2020
> 
> Modified Files:
> 	src/usr.bin/make: var.c
> 
> Log Message:
> make(1): fix :hash modifier on 16-bit platforms
> 
> On platforms where int has only 16 bits the shifts would have been in
> 16-bit arithmetic, which would invoke undefined behavior for "ustr[3] <<
> 24" as well as "ustr[2] << 16" (C99, 6.5.7p3).

WTF should we care? This is just making things more complicated without
adding any value.

Joerg


Home | Main Index | Thread Index | Old Index