Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/common/lib/libprop



On 12.06.2020 01:11, Joerg Sonnenberger wrote:
> On Fri, Jun 12, 2020 at 12:58:45AM +0200, Kamil Rytarowski wrote:
>> On 12.06.2020 00:55, Christos Zoulas wrote:
>>> In article <20200611222544.6D3A6FB28%cvs.NetBSD.org@localhost>,
>>> Joerg Sonnenberger <source-changes-d%NetBSD.org@localhost> wrote:
>>>> -=-=-=-=-=-
>>>>
>>>> Module Name:	src
>>>> Committed By:	joerg
>>>> Date:		Thu Jun 11 22:25:44 UTC 2020
>>>>
>>>> Modified Files:
>>>> 	src/common/lib/libprop: prop_object_impl.h
>>>>
>>>> Log Message:
>>>> Unbreak clang builds by removing questionable linker warning sections
>>>> trggered all over the place.
>>>
>>> Why don't you do this just for clang, so that we can use gcc to track the
>>> remaining ones down and finish the job? Now we can't easily find them.
>>>
>>> christos
>>>
>>
>> Can we please revert this and fix clang?
>>
>> I'm strongly for linker warnings as they catch real issues.
> 
> Repeating that statement doesn't make it true. The amount of legit
> problems found by them is dwarfed by far by the number of false
> positives seen. That's complete ignoring basic QoI issues like "where is
> this actually triggered" and no "I know, shut up".
> 
> Joerg
> 

Please list legitimate false positives. There is practically nothing
like that possible for using deprecated APIs (at least kept longer
term). Besides that, the report shall be lowered to warning (like it
used to be for Clang).


Attachment: signature.asc
Description: OpenPGP digital signature



Home | Main Index | Thread Index | Old Index