Re: CVS commit: src

[Yorick Hardy <yorickhardy%gmail.com@localhost>]

Dear Martin,

On 2020-05-07, Martin Husemann wrote:
> On Thu, May 07, 2020 at 12:31:12AM +0200, Yorick Hardy wrote:
> > I think this test depends on MKCOMPAT=yes. Does the attached the patch
> > below look reasonable?
> [..]
> > -.if ${MACHINE} == "amd64"
> > +.if ${MACHINE} == "amd64" && ${MKCOMPATTESTS} == "yes"
> 
> MKCOMPATTESTS is something slightly different. It is used to build e.g. the
> "native" i386 tests (as 32bit binaries) when building an amd64 distribution.
> 
> This is usually set to "no".
> 
> MKCOMPAT=yes means to build i386 libraries, so you can build 32bit binaries
> on amd64 with -m32. It is usually set to "yes".
> 
> Martin

Thanks! It took a while for this to sink in ...

So I think the test should only be built if MKCOMPAT=yes ?
(It does fail to build for me, because I usually have MKCOMPAT=no).

-- 
Kind regards,

Yorick Hardy