Re: CVS commit: src/sys/dev/ata

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

After this commit, NetBSD/amd64-current on my HP Spectre x360
freezes after acpiacad0 detection (before ld0 detection).
Reverting this commit in latest tree fixes my freeze problem.

Could you take a look at my problem?

Thank you.

=== === ===
cpu7: CPU max freq 4000000000 Hz
cpu7: TSC freq 1992000000 Hz
timecounter: Timecounter "TSC" frequency 1992000000 Hz quality 3000
uhub0 at usb0: NetBSD (0x0000) xHCI root hub (0x0000), class 9/0, rev 3.00/1.00,
 addr 0
uhub0: 6 ports with 6 removable, self powered
uhub1 at usb1: NetBSD (0x0000) xHCI root hub (0x0000), class 9/0, rev 2.00/1.00,
 addr 0
uhub1: 12 ports with 12 removable, self powered
acpiacad0: AC adapter online.

(With this commit, freeze here)

ld0: GPT GUID: 3fda58df-424f-4b48-9fb9-b4c5c037379e
dk0 at ld0: "EFI", 262144 blocks at 2048, type: ntfs
dk1 at ld0: "ROOT", 66955885 blocks at 266240, type: ffs
=== === ===

"Jason R Thorpe" <thorpej%netbsd.org@localhost> writes:

> Module Name:	src
> Committed By:	thorpej
> Date:		Sat Apr 25 00:07:27 UTC 2020
>
> Modified Files:
> 	src/sys/dev/ata: ata.c ata_subr.c atavar.h
>
> Log Message:
> Rather than creating a kthread-per-channel, use a threadpool and a
> threadpool-job-per-channel for the in-thread-context work that needs
> to be done (which is rare).
>
> On one of my test systems, this results in the total number of LWPs
> after multi-user boot dropping from 116 to 78.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.155 -r1.156 src/sys/dev/ata/ata.c
> cvs rdiff -u -r1.9 -r1.10 src/sys/dev/ata/ata_subr.c
> cvs rdiff -u -r1.105 -r1.106 src/sys/dev/ata/atavar.h
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3