Re: CVS commit: src

[Paul Goyette <paul%whooppee.com@localhost>]

On Sun, 26 Apr 2020, Maxime Villard wrote:

> Le 26/04/2020 à 14:05, Paul Goyette a écrit :
> > Why are these files being placed in src/tests/modules?
>
> Because I modeled my tests after the ufetchstore and threadpool tests
> which are both in this directory and provide user access to kernel
> internals via modules, which is exactly what I'm doing.
>
> Also it looks like the t_kcov one doesn't match your definition of
> what this directory should be about.

Yes, those are also mis-placed.

> > That directory is supposed to contain tests of the module feature;
> > it is not intended to place modules-that-support-tests-of-other-
> > features.
> >
> > Can you please put these in src/tests/sys/ or somewhere more
> > appropriate?
> >
> >
> >
> >
> > On Sun, 26 Apr 2020, Maxime Villard wrote:
> >
> > > Module Name:    src
> > > Committed By:    maxv
> > > Date:        Sun Apr 26 09:08:41 UTC 2020
> > >
> > > Modified Files:
> > >     src/distrib/sets/lists/debug: md.amd64
> > >     src/distrib/sets/lists/tests: md.amd64
> > >     src/tests/modules: Makefile
> > > Added Files:
> > >     src/tests/modules: t_x86_pte.c
> > >     src/tests/modules/x86_pte_tester: Makefile x86_pte_tester.c
> > >
> > > Log Message:
> > > Add tests on the x86 PTEs. We scan the MMU page tables directly and verify
> > > certain properties.
> > >
> > >
> > > To generate a diff of this commit:
> > > cvs rdiff -u -r1.107 -r1.108 src/distrib/sets/lists/debug/md.amd64
> > > cvs rdiff -u -r1.8 -r1.9 src/distrib/sets/lists/tests/md.amd64
> > > cvs rdiff -u -r1.18 -r1.19 src/tests/modules/Makefile
> > > cvs rdiff -u -r0 -r1.1 src/tests/modules/t_x86_pte.c
> > > cvs rdiff -u -r0 -r1.1 src/tests/modules/x86_pte_tester/Makefile \
> > >    src/tests/modules/x86_pte_tester/x86_pte_tester.c
> > >
> > > Please note that diffs are not public domain; they are subject to the
> > > copyright notices on the relevant files.
> >
> > +--------------------+--------------------------+-----------------------+
> > | Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
> > | (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
> > | Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
> > +--------------------+--------------------------+-----------------------+
>
> !DSPAM:5ea57d44212103157353641!

+--------------------+--------------------------+-----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
+--------------------+--------------------------+-----------------------+