Re: CVS commit: src/sys/modules/compat_netbsd32

[Maxime Villard <max%m00nbsd.net@localhost>]

I almost got a heart attack between your first email and your second one,
wondering how this code got re-enabled. Thanks for clarifying.

Relevant example, by the way.

Committed on August 20th 2019 at 09:32

	https://mail-index.netbsd.org/source-changes/2019/08/20/msg108321.html

Disabled by me the same day at 12:25

	https://mail-index.netbsd.org/source-changes/2019/08/20/msg108332.html

No rocket science here, I just saw that the code qualified as close to
structurally deficient, and went ahead. In case you people are wondering,
I think I did it with strictly no discussion.

Unsurprisingly, it looks like it has saved us a lot of trouble here.

This is what sane policy looks like.


Le 19/04/2020 à 19:58, maya%NetBSD.org@localhost a écrit :
> Good news everyone. Does not affect any release at all.
> Also might not have been a security issue, because christos did a weird
> thing where it is compiled but somehow still disabled.
> 
> On Sun, Apr 19, 2020 at 05:40:50PM +0000, Maya Rashish wrote:
>> Module Name:	src
>> Committed By:	maya
>> Date:		Sun Apr 19 17:40:50 UTC 2020
>>
>> Modified Files:
>> 	src/sys/modules/compat_netbsd32: Makefile
>>
>> Log Message:
>> Turn off compat drm.
>> XXX issue security advisory
>>
>>
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.32 -r1.33 src/sys/modules/compat_netbsd32/Makefile
>>
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.
>>
> 
>> Modified files:
>>
>> Index: src/sys/modules/compat_netbsd32/Makefile
>> diff -u src/sys/modules/compat_netbsd32/Makefile:1.32 src/sys/modules/compat_netbsd32/Makefile:1.33
>> --- src/sys/modules/compat_netbsd32/Makefile:1.32	Thu Mar 12 15:02:29 2020
>> +++ src/sys/modules/compat_netbsd32/Makefile	Sun Apr 19 17:40:49 2020
>> @@ -1,13 +1,13 @@
>> -#	$NetBSD: Makefile,v 1.32 2020/03/12 15:02:29 pgoyette Exp $
>> +#	$NetBSD: Makefile,v 1.33 2020/04/19 17:40:49 maya Exp $
>>  
>>  .include "../Makefile.inc"
>>  .include "../Makefile.assym"
>>  
>>  KMOD=	compat_netbsd32
>>  
>> -.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "x86_64"
>> -NETBSD32_DRMKMS?=yes
>> -.endif
>> +#.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "x86_64"
>> +#NETBSD32_DRMKMS?=yes
>> +#.endif
>>  
>>  CPPFLAGS+=	-DCOMPAT_NETBSD32
>>  CPPFLAGS+=	-DEXEC_ELF32 -DEXEC_ELF64