On 24.02.2020 20:29, Christos Zoulas wrote:
> In article <20200222191457.87687FBF6%cvs.NetBSD.org@localhost>,
> Kamil Rytarowski <source-changes-d%NetBSD.org@localhost> wrote:
>> -=-=-=-=-=-
>>
>> Module Name: src
>> Committed By: kamil
>> Date: Sat Feb 22 19:14:57 UTC 2020
>>
>> Modified Files:
>> src/tests/lib/libc/gen: Makefile
>>
>> Log Message:
>> Update t_siginfo.c build rules
>>
>> Add logic for MKSANITIZER/MKLIBCSANITIZER checks.
>>
>>
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.53 -r1.54 src/tests/lib/libc/gen/Makefile
>>
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.
>>
>>
>> -=-=-=-=-=-
>>
>> Modified files:
>>
>> Index: src/tests/lib/libc/gen/Makefile
>> diff -u src/tests/lib/libc/gen/Makefile:1.53
>> src/tests/lib/libc/gen/Makefile:1.54
>> --- src/tests/lib/libc/gen/Makefile:1.53 Fri Apr 26 19:17:05 2019
>> +++ src/tests/lib/libc/gen/Makefile Sat Feb 22 19:14:57 2020
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.53 2019/04/26 19:17:05 maya Exp $
>> +# $NetBSD: Makefile,v 1.54 2020/02/22 19:14:57 kamil Exp $
>>
>> .include <bsd.own.mk>
>>
>> @@ -39,6 +39,10 @@ TESTS_C+= t_time
>> TESTS_C+= t_ttyname
>> TESTS_C+= t_vis
>>
>> +.if ${MKSANITIZER:Uno} != "yes" && ${MKLIBCSANITIZER:Uno} != "yes"
>> +COPTS.t_siginfo.c+= -DENABLE_TESTS
>> +.endif
>> +
>> CPPFLAGS.t_siginfo.c+=-D__TEST_FENV
>> COPTS.t_fpsetround.c+=${${ACTIVE_CC} == "gcc":? -frounding-math :}
>
> This should be backwards. -DDISABLE_TESTS for the sanitizers and nothing
> in the regular build case. Isn't there a cpp macro for the sanitizers?
>
Not a global one, but I can add it in our headers and switch to it,
avoiding the logic in Makefiles.
I still need to switch h_segv.c.
> christos
>
Attachment:
signature.asc
Description: OpenPGP digital signature