re: CVS commit: src/share/mk

[matthew green <mrg%eterna.com.au@localhost>]

"Maya Rashish" writes:
> Module Name:	src
> Committed By:	maya
> Date:		Sat Feb  8 21:16:53 UTC 2020
> 
> Modified Files:
> 	src/share/mk: sys.mk
> 
> Log Message:
> Don't special case aarch64 and add -fomit-frame-pointer to builds.
> 
> This behaviour is probably due to a past behaviour of clang, where it
> always emitted frame pointer code.
> This is no longer true for clang on netbsd, and I don't think it was true
> for GCC.
> 
> Meanwhile, this flag bleeds into pkgsrc where it breaks random packages,
> requiring workarounds like lang/ruby*-base/hacks.mk.

what sort of testing did you do with this change?  simply removing
it breaks the build.  and trying to fix it otherwise is hard.  see
only a month ago:

revision 1.142
date: 2020-01-08 14:04:24 -0800;  author: christos;  state: Exp;  lines: +1 -1;  commitid: NcvOnC9CgM4A5WRB;
Back out previous. This has no chance to work unless the make variable parsing
is not changed do that instead of scanning for a single character delim ':',
it scans for "?:". This is because !empty(COMPILE.c:M*-pg*) contains a ':'.
----------------------------
revision 1.141
date: 2020-01-07 20:15:45 -0800;  author: christos;  state: Exp;  lines: +2 -2;  commitid: U2dp6ScXDBHOaQRB;
tweak the DBG rule that -fomit-frame-pointer for aarch64 when profiling
(because the compiler complains), to use a match with the compile flags
and *pg*, instead of using a match to a target suffix (which is NetBSD
build-specific). Pointed out by phone@.


.mrg.