Re: CVS commit: src/sys/arch/arm/include/arm32

[christos%astron.com@localhost (Christos Zoulas)]

In article <200112121414.M0101112%mirage.ceres.dti.ne.jp@localhost>,
Izumi Tsutsui  <tsutsui%ceres.dti.ne.jp@localhost> wrote:
>> Module Name:	src
>> Committed By:	christos
>> Date:		Sat Jan 11 19:06:35 UTC 2020
>> 
>> Modified Files:
>> 	src/sys/arch/arm/include/arm32: vmparam.h
>> 
>> Log Message:
>> Define the min and max page size supported for the benefit of jemalloc
>> 
>> 
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.45 -r1.46 src/sys/arch/arm/include/arm32/vmparam.h
>
>--- src/sys/arch/arm/include/arm32/vmparam.h:1.45	Wed Jun 19 09:54:42 2019
>+++ src/sys/arch/arm/include/arm32/vmparam.h	Sat Jan 11 19:06:34 2020
>@@ -84,6 +84,11 @@
> #define	PAGE_SIZE	(1 << PAGE_SHIFT)
> #define	PAGE_MASK	(PAGE_SIZE - 1)
> 
>+#define	MIN_PAGE_SHIFT	12			/* normal */
>+#define	MAX_PAGE_SHIFT	13			/* _ARM_ARCH_6 */
>+#define	MIN_PAGE_SIZE	(1 << MIN_PAGE_SHIFT)
>+#define	MAX_PAGE_SIZE	(1 << MAX_PAGE_SHIFT)
>+
> /*
>  * Mach derived constants
>  */
>
>---
>
>m68k also needs this? (currently no common <m68k/vmparam.h> though)

Good catch. Yup, looks like it:

$ fgrep PGSHIFT {amiga,atari,hp300,luna68k,mac68k,mvme68k,next68k,sun2,sun3,x68k}/
param.h
amiga/include/param.h:#define   PGSHIFT         13              /* LOG2(NBPG) */
atari/include/param.h:#define   PGSHIFT         13              /* LOG2(NBPG) */
hp300/include/param.h:#define   PGSHIFT         12              /* LOG2(NBPG) */
luna68k/include/param.h:#define PGSHIFT         12              /* LOG2(NBPG) */
mac68k/include/param.h:#define  PGSHIFT         12              /* LOG2(NBPG) */
mvme68k/include/param.h:#define PGSHIFT         12              /* LOG2(NBPG) */
next68k/include/param.h:#define PGSHIFT         12              /* LOG2(NBPG) */
sun2/include/param.h:#define PGSHIFT            11              /* LOG2(NBPG) */
sun3/include/param.h:#define    PGSHIFT         13              /* LOG2(NBPG) */
x68k/include/param.h:#define    PGSHIFT         12              /* LOG2(NBPG) */

...

#define       MIN_PAGE_SHIFT  11                      /* sun2 */
#define       MAX_PAGE_SHIFT  13                      /* amiga,atari,sun3 */
#define       MIN_PAGE_SIZE   (1 << MIN_PAGE_SHIFT)
#define       MAX_PAGE_SIZE   (1 << MAX_PAGE_SHIFT)

Should I take care of it or can you?

christos