Re: CVS commit: src/sys/dev/pci

To: Masanobu SAITOH <msaitoh%execsw.org@localhost>
Subject: Re: CVS commit: src/sys/dev/pci
From: Jason Thorpe <thorpej%me.com@localhost>
Date: Thu, 9 Jan 2020 22:59:56 -0800

> On Jan 9, 2020, at 9:02 PM, Masanobu SAITOH <msaitoh%execsw.org@localhost> wrote:
> 
> The reason why I moved stge_softc to if_stgereg.h was that ipgphy.c
> required to check stge's chip revision. So, if there is no any objection,
> I'll make new if_stgevar.h and share it with if_stge.c and ipgphy.c.

That seems fine.  Although it might be preferable to set a property on the parent dev_t and then query that from ipgphy, rather than accessing the softc.

-- thorpej

Follow-Ups:
- Re: CVS commit: src/sys/dev/pci
  - From: Masanobu SAITOH

References:
- Re: CVS commit: src/sys/dev/pci
  - From: Jason Thorpe
- Re: CVS commit: src/sys/dev/pci
  - From: Masanobu SAITOH
- Re: CVS commit: src/sys/dev/pci
  - From: Jason Thorpe
- Re: CVS commit: src/sys/dev/pci
  - From: Masanobu SAITOH

Prev by Date: Re: CVS commit: src/sys/dev/pci
Next by Date: Re: CVS commit: src/sys/uvm
Previous by Thread: Re: CVS commit: src/sys/dev/pci
Next by Thread: Re: CVS commit: src/sys/dev/pci
Indexes:

Home | Main Index | Thread Index | Old Index