Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys




> On Jan 3, 2020, at 5:08 PM, Simon Burge <simonb%NetBSD.org@localhost> wrote:
> 
> Hey Jason,
> 
> Jason Thorpe wrote:
> 
>>> On Jan 3, 2020, at 10:11 AM, Frank Kardel <kardel%netbsd.org@localhost> wrote:
>>> 
>>> Hi Jason !
>>> 
>>> Could you please check that kmem using tools can cope with the missing _boottime symbol.
>> 
>> Hey Frank... this should fix it:
>> 
>> 	$NetBSD: vmstat.c,v 1.231 2020/01/03 19:13:54 thorpej Exp $
> 
> Is it worth keeping the boottime symbol about so that a netbsd-9 vmstat
> binary will still work with a -current kernel?  We could possibly wrap
> boottime with a COMPAT_90 check too?.

Define "work".  A dummy symbol would have no valid contents.  I guess if you call that "work" then go ahead?

The real problem here is that vmstat insists on finding the kernel symbols even if it's not going to use them, which is kind of silly.

-- thorpej



Home | Main Index | Thread Index | Old Index