Re: CVS commit: src/sys/arch/zaurus/conf

[Martin Husemann <martin%duskware.de@localhost>]

On Sat, Jan 04, 2020 at 03:42:20AM +0900, Izumi Tsutsui wrote:
> The problem is caused by sys/arch/arm/conf/Makefile.arm.
> It defines "COPTS+= -mapcs-frame" in recent rev 1.52
>  http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/arm/conf/Makefile.arm#rev1.52
> but MI sys/conf/Makefile.kern.inc defines COPTS+=-O2
> only if COPTS is empty.
>  
> This affects not only zaurus but all arm ports?

Yes! But only zaurus caused a build failure due to it.

> ---
> Index: sys/arch/arm/conf/Makefile.arm
> ===================================================================
> RCS file: /cvsroot/src/sys/arch/arm/conf/Makefile.arm,v
> retrieving revision 1.52
> diff -u -p -d -r1.52 Makefile.arm
> --- sys/arch/arm/conf/Makefile.arm	2 Jan 2020 14:33:55 -0000	1.52
> +++ sys/arch/arm/conf/Makefile.arm	3 Jan 2020 18:35:36 -0000
> @@ -78,7 +78,7 @@ CFLAGS+=	-mno-unaligned-access
>  
>  OPT_DDB=	%DDB%
>  .if !empty(OPT_DDB) && ${HAVE_GCC:U0} > 0
> -COPTS+=		-mapcs-frame
> +CFLAGS+=	-mapcs-frame
>  .endif
>  
>  ##

I wonder if we should make the handling in sys/conf/Makefile.kern.inc
"better" and avoid this dance. If anyone fixes it, please feel free to
back out my bandaid in sys/arch/zaurus/conf/Makefile.zaurus.

Martin