Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src



Le 21/12/2019 à 10:50, maya%NetBSD.org@localhost a écrit :
On Fri, Dec 20, 2019 at 06:34:31PM -0800, John Nemeth wrote:
      I don't wish to get embroiled in this debate (even if I did
start it by requesting the reversion).  I just want to point out
that there is a relatively simple way disable the autoloading of
a module.  From module(9):

            The directory from which the module is loaded will be searched for
            a file with the same name as the module file, but with the suffix
            ``.plist''.  If this file is found, the prop_dictionary it contains
            will be loaded and passed to the module's modcmd() routine.  If
            this prop_dictionary contains a ``noautoload'' property which is
            set to ``true'' then the system will refuse to load the module.

The simplest way to do the above is:

modload -p -b noautoload=true > <module>.plist

}-- End of excerpt from Maxime Villard

The first proposed change was to create a .plist file.
I liked it because it didn't require running postinstall to get the fix.

It provoked a bit of disgruntled voices, a continuation tech-kern bikeshed
about the correct way to disable module auto-loading in a per-module
basis.
Not installing the module allowed to avoid having to commit changes in a
debated topic (even though I was just using the existing method).
I was feeling rushed that we didn't commit something because of the excess
discussion.

I see. So you unilaterally pushed a controversial change in an expeditious
move, without any form of actual public discussion and approval.

Maxime


Home | Main Index | Thread Index | Old Index