Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/crunch/crunchgen



On Dec 19,  4:19pm, joerg%bec.de@localhost (Joerg Sonnenberger) wrote:
-- Subject: Re: CVS commit: src/usr.bin/crunch/crunchgen

| > I think that there are two uses: install media and rescue. I can reinstate
| > it for rescue. Is that ok? Note that by default both ssp and fortify are
| > off for most things, so my change was mostly a no-op for the default settings.
| 
| We seem to default to off for more things, PIE too for example.

Indeed, I also dislike the alphabet soup of flags for disabling
things.  I propose that instead we provide a way to add a preamble
to the generated Makefile via -f <preamble> file, default to a
either a built-in configuration file, or one installed in the tree.
It is inappropriate for crunchgen to have knowledge of variables
specific to our build system that change over time.

So I propose:

1. to make that change [configuration file]
2. leave the defaults as they are for the installation binaries
3. change the defaults to turn nothing off for the rescue binaries

christos


Home | Main Index | Thread Index | Old Index