Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/acorn32/acorn32



At least in certain domains of engineering 0 is a special case as it
does not need unit (km, lumen, kg, ...) neither base (hex, dec, ..).

It is natural (correct, expected) to print %#x for 0 as 0, without 0x.

On 04.10.2019 04:09, Christos Zoulas wrote:
> Thanks, and zero is special for 0#. Should I revert it?
> 
> christos
> 
>> On Oct 3, 2019, at 10:06 PM, Valery Ushakov <uwe%stderr.spb.ru@localhost> wrote:
>>
>>
>>> Modified Files:
>>> 	src/sys/arch/acorn32/acorn32: rpc_machdep.c
>>>
>>> Log Message:
>>> change 0x% -> %x
>>
>> This should read %#x.
>> And this is wrong.
>>
>> 1) With # the 0x is part of the width, so 
>>
>> 0x%08x -> 0x00000001
>> %#08x  -> 0x000001
>>
>> 0x00000000 0x00000001
>> 00000000 0x000001
>>
>> 2) # doesn't add prefix for zero, so 
>>
>> 0x%08x -> 0x00000000
>> %#08x  -> 00000000 
>>
>> -uwe
> 


Attachment: signature.asc
Description: OpenPGP digital signature



Home | Main Index | Thread Index | Old Index