Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/compat/netbsd32

Le 20/08/2019 à 11:32, Christos Zoulas a écrit :
Module Name:	src
Committed By:	christos
Date:		Tue Aug 20 09:32:21 UTC 2019

Modified Files:
	src/sys/compat/netbsd32: files.netbsd32 netbsd32_ioctl.c
Added Files:
	src/sys/compat/netbsd32: netbsd32_drm.c

Log Message:
compat32 drm ioctl support from Surya Shankar at GSoC 2019

To generate a diff of this commit:
cvs rdiff -u -r1.45 -r1.46 src/sys/compat/netbsd32/files.netbsd32
cvs rdiff -u -r0 -r1.1 src/sys/compat/netbsd32/netbsd32_drm.c
cvs rdiff -u -r1.103 -r1.104 src/sys/compat/netbsd32/netbsd32_ioctl.c
cvs rdiff -u -r1.67 -r1.68 src/sys/compat/netbsd32/netbsd32_ioctl.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Pieces of code like this one which touch kernel entry points should go through
proper reviewing because they can cause immense trouble. They should not be
committed and enabled by default blindly like you just did.

Here are my remarks:

1) In compat_drm_agp_info(), seems like it should be info64to32.

2) In compat_drm_getstats(), the assignments in the loop are inverted, it's
st32 which should be set to the values of st64, not the other way around.

3) In compat_drm_dma(), again inverted 32<->64, and there is no copyout (?).

4) In compat_drm_agp_enable(), m64 is uninitialized, everything is wrong in
this function it seems.

Etc, that's just after a quick glance. I will disable this code until it
receives proper review.

Home | Main Index | Thread Index | Old Index