Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/kern

On Fri, Aug 16, 2019 at 08:05:01AM +1000, matthew green wrote:
> "Maxime Villard" writes:
> > Module Name:	src
> > Committed By:	maxv
> > Date:		Thu Aug 15 12:06:42 UTC 2019
> > 
> > Modified Files:
> > 	src/sys/kern: subr_kmem.c
> > 
> > Log Message:
> > Retire KMEM_GUARD. It has been superseded by kASan, which is much more
> > powerful, has much more coverage - far beyond just kmem(9) -, and also
> > consumes less memory.
> was this discussed?
> KMEM_GUARD is useful for platforms that don't have kasan yet.

Not only was it not discussed, but also it is code removal w/o core approval.

Maxime: this does not mean you are not right, but even if you should be
right, this needs prior public discussion and a guide for others what
tools to use instead. You can not just use the big axe and later come up
piece by piece with necessary details to understand the change.

To you it may be clear (at least after your "instructions" in this thread),
but others may have trouble parsing or finding it later.


Home | Main Index | Thread Index | Old Index