This part has already been reverted: http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/rasops/rasops.c#rev1.92 IMO, the fail-safe alternate is preferable over tiny optimization and simplification with possible dangers. Thanks, rin On 2019/07/28 4:35, Joerg Sonnenberger wrote:
On Fri, Jul 26, 2019 at 07:54:15AM -0300, Jared McNeill wrote:On Fri, 26 Jul 2019, Rin Okuyama wrote:Also, convert loop of byte-wise copy into memset.I am a bit concerned about this change because IIRC there are platforms where memset etc. cannot be used on device memory.memset can access memory twice or alignment depending on the platform. The question is whether we care about that for the frame buffers though. Joerg