Re: CVS commit: src/sys/dev

[Ryo ONODERA <ryoon%netbsd.org@localhost>]

Hi,

Yorick Hardy <yorickhardy%gmail.com@localhost> writes:

> Dear Ryo,
>
> On 2019-07-09, Ryo ONODERA wrote:
>> Module Name:	src
>> Committed By:	ryoon
>> Date:		Tue Jul  9 12:52:51 UTC 2019
>> 
>> Modified Files:
>> 	src/sys/dev/hid: hidms.c hidms.h
>> 	src/sys/dev/i2c: ims.c
>> 
>> Log Message:
>> Add tpcalib, touch panel calibration to ims(4)
>> 
>> Suggested by ryo@ at Japan NetBSD Users' Group BOF 2019-07-06.
>> 
>> 
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.2 -r1.3 src/sys/dev/hid/hidms.c
>> cvs rdiff -u -r1.1 -r1.2 src/sys/dev/hid/hidms.h
>> cvs rdiff -u -r1.1 -r1.2 src/sys/dev/i2c/ims.c
>> 
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.
>
> I think this change has the side effect that ums(4) devices which
> report absolute coordinates seem to stop "moving" because
> tcpalib_init is never called for these devices.
>
> Is the patch below okay? Or, should hidms call tcpalib_init?
> (I tested the patch with an ACECAD digimemo.)

Sorry for breakage.
It looks good to me.
And I feel tpcalib_init should be called from ums.c like your patch.
Could you commit it?

Thank you.

> -- 
> Kind regards,
>
> Yorick Hardy
>
> Index: sys/dev/usb/ums.c
> ===================================================================
> RCS file: /cvsroot/src/sys/dev/usb/ums.c,v
> retrieving revision 1.93
> diff -u -r1.93 ums.c
> --- sys/dev/usb/ums.c	5 May 2019 03:17:54 -0000	1.93
> +++ sys/dev/usb/ums.c	24 Jul 2019 21:29:35 -0000
> @@ -192,6 +192,7 @@
>  		}
>  	}
>  
> +	tpcalib_init(&sc->sc_ms.sc_tpcalib);
>  	hidms_attach(self, &sc->sc_ms, &ums_accessops);
>  }
>  

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3