Re: CVS commit: src/usr.bin/printf

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Sun, 21 Jul 2019 15:25:39 +0000
Robert Elz <kre%netbsd.org@localhost> wrote:

> Module Name:	src
> Committed By:	kre
> Date:		Sun Jul 21 15:25:39 UTC 2019
> 
> Modified Files:
> 	src/usr.bin/printf: printf.c
> 
> Log Message:
> Stop assuming that printf handles options in any way at all
> (it doesn't - that is, shouldn't) which includes processing -- as an
> "end of options".  The first arg is (always) the format string.
> 
> Remove call to getopt() (but still do associated changes to argc/argv)
> 
> Note: for now this is #if 0's out instead of being deleted, the old
> code should be fully removed sometime soon.
> 
> Problem pointed out on tech-userlevel by Thierry Laronde.

Hi!

Please exercise caution when changing established userland behaviour.
This change broke the pkgsrc/lang/openjdk8(1) build. We can patch it of
course but there may be other software out there that expects the old
behaviour.

(1) https://hg.openjdk.java.net/jdk8u/jdk8u/file/bb03d4e1088a/make/common/MakeBase.gmk#l59

Kind regards,
-Tobias