re: CVS commit: src/sys/dev/usb

[matthew green <mrg%eterna.com.au@localhost>]

sc dying writes:
> hi,
> 
> On Sat, Jun 22, 2019 at 9:54 AM matthew green <mrg%netbsd.org@localhost> wrote:
> >
> > Module Name:    src
> > Committed By:   mrg
> > Date:           Sat Jun 22 09:53:56 UTC 2019
> >
> > Modified Files:
> >         src/sys/dev/usb: if_axen.c
> >
> > Log Message:
> > mark this driver MPSAFE for usb tasks and pipes, if(4), and callouts.
> > remove remaining redundant spl calls.
> 
> Should ether_ioctl be wrapped with splnet?
> ure, cdce and usmsc also need splnet.

splnet is obsolete in modern USB network drivers.
all the code runs at softipl.

removing spl was done entirely on purpose.

> Should if_percpuq_enqueue be called with rxlock held?
> I'm not sure, but I cannot find the reason it is called
> after rxlock is unlocked.

if_percpuq_enqueue() wants to be called with no locks held.


.mrg.