Re: CVS commit: src/sys/ufs

[Paul Goyette <paul%whooppee.com@localhost>]

On Sun, 16 Jun 2019, Christos Zoulas wrote:

> I did not rearrange where things live (or I don't understand what you
> mean by that).  I just uncommented the no filesystem FFS from MODULAR,
> and tried to compile.

The various sys/modules/*/Makefiles also specifically include the same 
files in the modules.  For example, the ffs module has

SRCS=   ufs_bmap.c ufs_dirhash.c ufs_extattr.c ufs_inode.c \
        ufs_lookup.c ufs_quota.c ufs_quota1.c ufs_quota2.c ufs_rename.c \
        ufs_vfsops.c ufs_vnops.c ufs_wapbl.c quota2_subr.c

If I'm understanding your changes correctly, a kernel will have a copy
of ufs_quota.c built-in, whether or not the ffs code is built-in.  So
if you have a kernel with no ffs, that kernel will still have the quota
code, and loading the ffs module will result in duplicate symbols.  The
error will occur at module load/link time, not at kernel build/link.


> Does it compile for you without my changes?

Yes, it compiled and linked successfully for me, for both of

	it == GENERIC kernel with all standard filesystems
  and	it == kernel with no filesystems of any sort included


+--------------------+--------------------------+-----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
+--------------------+--------------------------+-----------------------+