Re: CVS commit: src/distrib/sets/lists/comp

[Maxime Villard <max%m00nbsd.net@localhost>]

Can we revert the whole thing now please?

RDMSR/WRMSR are privileged instructions, and cannot work in cpuctl. I
don't understand how adding RDMWR/WRMSR in cpuctl could have possibly
worked on any AMD configuration.

There is PR/54220, now.


Le 11/05/2019 à 15:32, Christos Zoulas a écrit :
> Well, the code in cpuctl calls rdmsr() and the build was broken. Please fix it properly (and refrain from cursing on the lists while you are at it).
>
> christos
>
> > On May 11, 2019, at 9:08 AM, Maxime Villard <max%m00nbsd.net@localhost> wrote:
> >
> > What the fuck are you all doing?
> >
> > Last I heard, RDMSR/WRMSR are privileged instructions, not executable in
> > userland.
> >
> >
> > Le 11/05/2019 à 15:04, Christos Zoulas a écrit :
> > > Module Name:	src
> > > Committed By:	christos
> > > Date:		Sat May 11 13:04:40 UTC 2019
> > > Modified Files:
> > > 	src/distrib/sets/lists/comp: md.i386
> > > Log Message:
> > > Add cpufunc.h
> > > To generate a diff of this commit:
> > > cvs rdiff -u -r1.187 -r1.188 src/distrib/sets/lists/comp/md.i386
> > > Please note that diffs are not public domain; they are subject to the
> > > copyright notices on the relevant files.