re: CVS commit: [isaki-audio2] src/sys/dev/usb

[matthew green <mrg%eterna.com.au@localhost>]

"Tetsuya Isaki" writes:
> Module Name:	src
> Committed By:	isaki
> Date:		Wed May  1 13:09:34 UTC 2019
> 
> Modified Files:
> 	src/sys/dev/usb [isaki-audio2]: uaudio.c
> 
> Log Message:
> Don't release sc_lock and sc_intr_lock in trigger_{input,output}.
> In the past, sc_lock was IPL_SCHED and (probably) it had conflicted
> with usb subroutines.  But at some point, sc_lock has changed to use
> IPL_SOFTUSB so such problems should been gone.

sc_lock was ever IPL_SCHED.  only sc_intr_lock has been
that in uaudio.

what are you trying to avoid here?  the problem this
solved was not always a problem, but eg:

- drop the audio thread lock when calling into usb when it may sleep,
  avoiding a deadlock between audiowrite and audioioctl.  this fixes
  mixerctl -a vs. playing hanging the system
  XXX probably need to check this in a bunch more places.

is the commit related to that change.  can you confirm
that you can be playing and run mixerctl -a at the same
time with your change in place?

thanks.


.mrg.