On 10.03.2019 10:21, Kamil Rytarowski wrote: > On 10.03.2019 10:00, Tom Ivar Helbekkmo wrote: >> Christos Zoulas <christos%netbsd.org@localhost> writes: >> >>> Module Name: src >>> Committed By: christos >>> Date: Sun Mar 10 02:49:52 UTC 2019 >>> >>> Modified Files: >>> src/external/bsd/jemalloc/dist/src: jemalloc.c >>> src/external/bsd/jemalloc/include/jemalloc: jemalloc.h >>> src/external/bsd/jemalloc/lib: Makefile.inc >>> >>> Log Message: >>> Make the non-standard jemalloc api weak. >>> >>> >>> To generate a diff of this commit: >>> cvs rdiff -u -r1.2 -r1.3 src/external/bsd/jemalloc/dist/src/jemalloc.c >>> cvs rdiff -u -r1.1 -r1.2 \ >>> src/external/bsd/jemalloc/include/jemalloc/jemalloc.h >>> cvs rdiff -u -r1.3 -r1.4 src/external/bsd/jemalloc/lib/Makefile.inc >> >> I'm wondering if you perhaps misspelled je_mallctlnametomib as just >> je_mallctltomib when you made this change...? >> >> -tih >> > > This breaks the build for me. > > /public/netbsd-root/tooldir.NetBSD-8.99.35-amd64/lib/gcc/x86_64--netbsd/7.4.0/../../../../x86_64--netbsd/bin/ld: > /public/netbsd--root/destdir.amd64/lib/libc.so: undefined reference to > `je_mallctltomib' > collect2: error: ld returned 1 exit status > I've pushed a fix to unbreak the build. Now we have a mismatch mallctlnametomib vs mallctltomib in malloc.h. Which one is correct?
Attachment:
signature.asc
Description: OpenPGP digital signature