Re: CVS commit: src

[Martin Husemann <martin%homeworld.netbsd.org@localhost>]

On Sat, Feb 23, 2019 at 03:10:07AM +0000, Kamil Rytarowski wrote:
> Module Name:	src
> Committed By:	kamil
> Date:		Sat Feb 23 03:10:06 UTC 2019
> 
> Modified Files:
> 	src/distrib/sets/lists/comp: mi
> 	src/distrib/sets/lists/man: mi
> 	src/distrib/sets/lists/tests: module.mi
> 	src/etc: MAKEDEV.tmpl
> 	src/share/man/man4: Makefile
> 	src/share/mk: bsd.sys.mk
> 	src/sys/arch/amd64/conf: GENERIC
> 	src/sys/conf: files majors ssp.mk
> 	src/sys/kern: files.kern
> 	src/sys/sys: Makefile
> 	src/tests/modules: Makefile
> Added Files:
> 	src/share/man/man4: kcov.4
> 	src/sys/kern: subr_kcov.c
> 	src/sys/sys: kcov.h
> 	src/tests/modules: t_kcov.c
> 
> Log Message:
> Add KCOV - kernel code coverage tracing device

Please add this also to amd64/conf/ALL and i386/conf/ALL.

The use of both makeoptions KCOV=1 and options KCOV looks pretty ugly, any
way we can get by with one of them? If not, please add comments explaining
what they mean.

subr_kcov.c does not seem to need the <sys/atomic.h> include.

kcov_int_t can not be uint64_t, as that requires 64bit atomic instructions,
which are not available everywhere (see __HAVE_ATOMIC64_OPS).

Martin