Re: CVS commit: src/sys/external/bsd/libnv/dist

[Martin Husemann <martin%duskware.de@localhost>]

On Fri, Feb 15, 2019 at 11:21:51PM +0000, Mindaugas Rasiukevicius wrote:
> Well, I did run libnv tests as well as NPF tests and they both passed,
> just not on NetBSD. :)  Turns out NetBSD libnv and Github libnv code
> bases deviated a little bit, causing a bug in NetBSD (but not upstream).
> Anyway, I committed the fix.  As for the NetBSD tests: it takes forever
> to recompile and rerun them, so it is not really practical for me.

You can recompile parts of it and also run sub-tests (like in this
case: the npf tests, which would have taken like 10 min combined),
and you do not need to run the (sub-) tests on qemu.

You could post patches and ask for others to include the patches in
their next test runs.

The "not practical" bit sounds to me like "I am in a hurry, I can not
deal properly with it", which feels slightly wrong.

But you dealt with the fallout and this is -current, so no big deal and
thank you for fixing it!

Martin