Re: CVS commit: src/sys/dev/usb

[Michael van Elst <mlelstv%serpens.de@localhost>]

On Sat, Feb 09, 2019 at 05:15:51PM +0900, Rin Okuyama wrote:
> On 2019/02/08 7:51, Michael van Elst wrote:
> > On Fri, Feb 08, 2019 at 07:12:28AM +0900, Rin Okuyama wrote:
> > > Hi,
> > > 
> > > What compiler options (or version, architecture, etc.) do you use?
> > > I want to enable that warnings, but I cannot even with WARNS=5.
> > 
> > The warnings came for assertions, so you need to build with DIAGNOSTIC,
> > which is default for all archs.
> 
> Ah, thanks. That's why WARN=5 build passes for modules.

And that's why I see it for modules:

Index: sys/modules/Makefile.inc
===================================================================
RCS file: /cvsroot/src/sys/modules/Makefile.inc,v
retrieving revision 1.6
diff -p -u -r1.6 Makefile.inc
--- sys/modules/Makefile.inc    11 Sep 2011 18:38:02 -0000      1.6
+++ sys/modules/Makefile.inc    9 Feb 2019 10:53:03 -0000
@@ -1,7 +1,7 @@
 #      $NetBSD: Makefile.inc,v 1.6 2011/09/11 18:38:02 mbalmer Exp $
 
 S!=            cd ${.PARSEDIR}/..;pwd
-CPPFLAGS+=     -I${NETBSDSRCDIR}/common/include
+CPPFLAGS+=     -I${NETBSDSRCDIR}/common/include -DDIAGNOSTIC
 USE_FORT=      no
 WARNS?=                3


Greetings,
-- 
                                Michael van Elst
Internet: mlelstv%serpens.de@localhost
                                "A potential Snark may lurk in every tree."