Re: CVS commit: src

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Mon, Dec 31, 2018 at 07:33:08PM +0000, Maya Rashish wrote:
> Module Name:	src
> Committed By:	maya
> Date:		Mon Dec 31 19:33:07 UTC 2018
> 
> Modified Files:
> 	src/distrib/sets/lists/comp: mi
> 	src/etc/mtree: NetBSD.dist.base
> 	src/external/bsd/llvm/include: Makefile
> Added Files:
> 	src/external/bsd/llvm/include: Makefile.inc
> 	src/external/bsd/llvm/include/llvm: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm-c: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm-c/Transforms: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm-c/Transforms/AggressiveInstCombine:
> 	    Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm-c/Transforms/IPO: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm-c/Transforms/InstCombine: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm-c/Transforms/Instrumentation:
> 	    Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm-c/Transforms/Scalar: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm-c/Transforms/Utils: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm-c/Transforms/Vectorize: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/ADT: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Analysis: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/AsmParser: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/BinaryFormat: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/BinaryFormat/ELFRelocs: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Bitcode: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/CodeGen: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Config: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/DebugInfo: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/DebugInfo/CodeView: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Demangle: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/ExecutionEngine: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/FuzzMutate: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/IR: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/IRReader: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/LTO: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/LineEditor: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Linker: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/MC: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Object: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/ObjectYAML: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Option: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Passes: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/ProfileData: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/ProfileData/Coverage: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Support: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/TableGen: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Target: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Transforms: Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Transforms/AggressiveInstCombine:
> 	    Makefile Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Transforms/IPO: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Transforms/InstCombine: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Transforms/Instrumentation: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Transforms/Scalar: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Transforms/Utils: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/Transforms/Vectorize: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/WindowsManifest: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/WindowsResource: Makefile
> 	    Makefile.inc
> 	src/external/bsd/llvm/include/llvm/XRay: Makefile Makefile.inc
> 
> Log Message:
> Install most of the llvm headers.
> 
> This is missing some generated files, llvm/include/IR/*.inc

Can you please not do such changes without proper discussion? I'm *very*
strongly against this. At the very least it is not useful in this form
and before any kind of decision on the ABI stability we are willing to
commit for LLVM is made, this should never have been committed. As is,
it should be reverted.

Joerg