Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Weak x86 aliases



On December 28, 2018 11:28:01 PM GMT+05:30, Jason Thorpe <thorpej%me.com@localhost> wrote:
>
>> On Dec 28, 2018, at 9:50 AM, Mathew, Cherry G. <cherry%zyx.in@localhost> wrote:
>> 
>> That seems like a dependency burden on people developing new
>features. I can't tell if modload is the only way to get NVMM to run.
>If it is, then ok. If not, then there's the option of provisionally
>turning it off until we fix the underlying problem.
>
>Uh, no :-)  This would have been exactly the same situation if you had
>changed some other symbol to be a weak-alias.  NVMM was using an
>exported symbol, no different from how a module might use, say,
>kmem_zalloc(), and you changed the semantics of that symbol in a way
>that broke a module using it.
>
>-- thorpej

ic, this probably explains why it's used sparingly so far. Thanks for the explanation. I'll try to educate myself on this wrt enabling this for modload.

The other option for me is a bunch of ugly #ifdefs , which I'm trying to minimise.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Home | Main Index | Thread Index | Old Index