Re: Weak x86 aliases

["Mathew, Cherry G." <cherry%zyx.in@localhost>]

On December 28, 2018 7:58:10 PM GMT+05:30, Maxime Villard <max%m00nbsd.net@localhost> wrote:
>Le 28/12/2018 à 15:06, Cherry G.Mathew a écrit :
>> Maxime Villard <max%m00nbsd.net@localhost> writes:
>>> Le 28/12/2018 à 14:57, Cherry G.Mathew a écrit :
>>>> Maxime Villard <max%m00nbsd.net@localhost> writes:
>>>>>> Introduce a weak alias method of exporting different
>implementations
>>>>>> of the same API.
>>>>>
>>>>> Please revert or fix this change.
>>>>
>>>> I'm not sure what the fix is - do you have a suggestion ?
>>>
>>> either re-apply it without using weak symbols, or change the
>modloader
>>> to accept weak symbols
>> 
>> I don't like the imperative in your tone. NVMM is the user of
>modloader,
>> not PVHVM. So if you feel like your usecase needs fixing, I'd say
>it's
>> your problem - or don't use modules, but see below.
>
>Wut? Yes my suggestions are either we re-apply the change without using
>weak symbols or we change the modloader to accept weak symbols.
>

It's ok for the diff involving the specific function, but in general, we'll need option #2 because I can't see a less intrusive way to dynamic switching between native and PV.

...
>
>That's fine, I can hard-code the check on my side for now, to make it
>load.

Thanks, appreciate it.

I'll have a look at the kobj thing.

Cherry

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.