Re: CVS commit: src/sys/uvm

[Jaromír Doleček <jaromir.dolecek%gmail.com@localhost>]

Good point, added asserts in genfs_io.c for this.
Le dim. 9 déc. 2018 à 23:56, matthew green <mrg%eterna.com.au@localhost> a écrit :
>
> "Jaromir Dolecek" writes:
> > Module Name:  src
> > Committed By: jdolecek
> > Date:         Sun Dec  9 20:45:37 UTC 2018
> >
> > Modified Files:
> >       src/sys/uvm: uvm_bio.c
> >
> > Log Message:
> > for direct map case, avoid PGO_NOBLOCKALLOC when writing, it makes
> > genfs_getpages() return unallocated pages using the zero page and
> > PG_RDONLY; the old code relied on fault logic to get it allocated, which
> > the direct case can't rely on
> >
> > instead just allocate the blocks right away; pass PGO_JOURNALLOCKED
> > so that code wouldn't try to take wapbl lock, this code path is called
> > with it already held
>
> can you assert this if not already done?  that the locking is OK,
> i mean...
>
> thanks.
>
>
> .mrg.