Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys



On Sat, Dec 08, 2018 at 05:46:15PM +0000, Jason R Thorpe wrote:
> @@ -2508,13 +2525,7 @@ comcnattach(bus_space_tag_t iot, bus_add
>  {
>  	struct com_regs	regs;
>  
> -	memset(&regs, 0, sizeof regs);
> -	regs.cr_iot = iot;
> -	regs.cr_iobase = iobase;
> -	regs.cr_nports = COM_NPORTS;
> -#ifdef	COM_REGMAP
> -	memcpy(regs.cr_map, com_std_map, sizeof (regs.cr_map));
> -#endif
> +	com_init_regs(&regs, iot, (bus_space_handle_t)0/*XXX*/, iobase);
>  
>  	return comcnattach1(&regs, rate, frequency, type, cflag);
>  }

This breaks the build for sparc:
https://releng.netbsd.org/builds/HEAD/201812090350Z/sparc64.build.failed

/home/source/ab/HEAD/src/sys/dev/ic/com.c: In function 'comcnattach':
/home/source/ab/HEAD/src/sys/dev/ic/com.c:2511:2: error: conversion to non-scalar type requested
  com_init_regs(&regs, iot, (bus_space_handle_t)0/*XXX*/, iobase);
  ^~~~~~~~~~~~~

Any idea?


Home | Main Index | Thread Index | Old Index