Re: CVS commit: src/sys

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 29/11/2018 à 19:51, Christos Zoulas a écrit :
> In article <20181129174012.9AD90FB20%cvs.NetBSD.org@localhost>,
> Maxime Villard <source-changes-d%NetBSD.org@localhost> wrote:
> > -=-=-=-=-=-
> >
> > Module Name:	src
> > Committed By:	maxv
> > Date:		Thu Nov 29 17:40:12 UTC 2018
> >
> > Modified Files:
> > 	src/sys/compat/linux/common: linux_misc_notalpha.c
> > 	src/sys/kern: kern_time.c
> >
> > Log Message:
> > Improve my kern_time.c::rev1.192, systematically clear the buffers we get
> > from 'ptimer_pool' to prevent more leaks.
>
> Shouldn't those pools be converted to pool_cache_*() so that we can use
> constructors to avoid sprinking memset() all over the place?
>
> christos

I thought about it, but I ended up telling myself that it was better not to
completely modify the allocator just add a memset constructor, and that it
was easier to add the memset after the allocation rather than inside.

The pool is just called three times, so it's not a big deal.