Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/external/apache2/mDNSResponder/dist/mDNSPosix



    Date:        Mon, 19 Nov 2018 03:14:28 -0500
    From:        "Christos Zoulas" <christos%netbsd.org@localhost>
    Message-ID:  <20181119081428.DEF1CFB1F%cvs.NetBSD.org@localhost>

  | Modified Files:
  |	src/external/apache2/mDNSResponder/dist/mDNSPosix: mDNSPosix.c


  | It is not an error if we did not find any IPv4 interfaces. It could
  | be the case we never have V4 interfaces (in a V6 system) so this
  | is bogus.

Rather than just removing the test, a better fix would be to move it
to after the v6 interfaces are added?    That way it really would be
testing if there are no interfaces at all (in which case this code is
not going to accomplish much).

Otherwise, the "err" variable should just be removed, and the function
made to return 0 as "err" is init'd to 0, tested a couple of times, and then
returned (but never updated) as the code stands now.

kre



Home | Main Index | Thread Index | Old Index