Re: CVS commit: src/sys/dev/usb

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

"Emmanuel Dreyfus" writes:
>Module Name:    src
>Committed By:   manu
>Date:           Thu Nov 15 02:35:23 UTC 2018
>
>Modified Files:
>        src/sys/dev/usb: usb_quirks.c usb_quirks.h usbdi.c
>
>Log Message:
>Workaround NBP PN533 USB toggle bit bugs

Hello,

This has broken a macppc build for me as follows:

#   compile  ARCUSV_DEBUG/usbdi.o
/usr/builds/netbsd-current/src/obj/tooldir.NetBSD-8.0_STABLE-i386/bin/powerpc--netbsd-gcc -pipe -O2 -mno-strict-align -Wa,-maltivec -msdata=none -msoft-float -ffreestanding -fno-zero-initialized-in-bss -fno-delete-null-pointer-checks -pipe -O2 -mcpu=750 -fno-strict-aliasing -fno-common -std=gnu99 -Werror -Wreturn-type -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wold-style-definition -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wno-unreachable-code -Wno-pointer-sign -Wno-attributes -Wno-sign-compare -mcpu=750 --sysroot=/usr/builds/netbsd-current/src/obj/destdir.macppc -Dmacppc=macppc -I. -I/usr/builds/netbsd-current/src/sys/external/bsd/libnv/dist -I/usr/builds/netbsd-current/src/sys/../common/lib/libx86emu -I/usr/builds/netbsd-current/src/sys/../common/lib/libc/misc -I/usr/builds/netbsd-current/src/sys/../common/include -I/usr/builds/netbsd-current/src/sys/arch -I/usr/builds/netbsd-current/src/sys -nostdinc -DDIAGNOSTIC -DDEBUG -DZS_CONSOLE_ABORT -DFORCE_FUNCTION_KEYS -D_KERNEL -D_KERNEL_OPT -std=gnu99 -I/usr/builds/netbsd-current/src/sys/lib/libkern/../../../common/lib/libc/quad -I/usr/builds/netbsd-current/src/sys/lib/libkern/../../../common/lib/libc/string -I/usr/builds/netbsd-current/src/sys/lib/libkern/../../../common/lib/libc/arch/powerpc/string -I/usr/builds/netbsd-current/src/sys/external/bsd/ipf -I/usr/builds/netbsd-current/src/sys/dist/pf -c /usr/builds/netbsd-current/src/sys/dev/usb/usbdi.c -o usbdi.o
In file included from /usr/builds/netbsd-current/src/sys/dev/usb/usbhist.h:45:0,
                 from /usr/builds/netbsd-current/src/sys/dev/usb/usbdi.c:58:
/usr/builds/netbsd-current/src/sys/dev/usb/usbdi.c: In function 'usb_transfer_complete':
/usr/builds/netbsd-current/src/sys/sys/kernhist.h:226:14: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
  _e_->v[0] = (uintmax_t)(A); \
              ^
/usr/builds/netbsd-current/src/sys/dev/usb/usbhist.h:58:3: note: in expansion of macro 'KERNHIST_LOG'
   KERNHIST_LOG(usbhist,FMT,A,B,C,D);  \
   ^~~~~~~~~~~~
/usr/builds/netbsd-current/src/sys/dev/usb/usbhist.h:66:39: note: in expansion of macro 'USBHIST_LOGN'
 #define USBHIST_LOG(NAME,FMT,A,B,C,D) USBHIST_LOGN(NAME,1,FMT,A,B,C,D)
                                       ^~~~~~~~~~~~
/usr/builds/netbsd-current/src/sys/dev/usb/usbdi.c:925:3: note: in expansion of macro 'USBHIST_LOG'
   USBHIST_LOG(usbdebug, "Possible output ack miss for xfer %#jx: "
   ^~~~~~~~~~~
cc1: all warnings being treated as errors
*** [usbdi.o] Error code 1

Regards,

Dave