Re: CVS commit: src/lib/libnvmm

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 11/11/2018 à 01:06, Maya Rashish a écrit :
> Module Name:	src
> Committed By:	maya
> Date:		Sun Nov 11 00:06:48 UTC 2018
>
> Modified Files:
> 	src/lib/libnvmm: libnvmm_x86.c
>
> Log Message:
> Add missing include for struct nvmm_x64_state
> (Pointed out by the clang build)
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.1 -r1.2 src/lib/libnvmm/libnvmm_x86.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

?

libnvmm_x86.c includes "nvmm.h", which includes <dev/nvmm/x86/nvmm_x86.h>

     40 #ifdef __x86_64__
     41 #include <dev/nvmm/x86/nvmm_x86.h>
     42 #endif

Is there rather a problem with the ifdef? It's the second time someone
tells me libnvmm doesn't build, yet on my machine it builds.