Re: CVS commit: src/sys/dev/pci

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

On 2018/11/02 17:04, SAITOH Masanobu wrote:
> Module Name:	src
> Committed By:	msaitoh
> Date:		Fri Nov  2 08:04:42 UTC 2018
>
> Modified Files:
> 	src/sys/dev/pci: if_wm.c
>
> Log Message:
>   Fix a PCH2 specific bug that wrong register value can be read when boot.
> When a wrong value is read when boot, the read device ID was incorrect and
> ukphy(3) is attached instead of ihphy(4). The bug might also result in
> MDIC read/write error.
>
>   How to reproduce:
>
>    0) Boot Windows.
>    1) Leave some minutes.
>    2) Reboot to NetBSD.

 To reproduce this problem, the PHY link should be down
(don't connect Ethernet cable).

>   To fix this problem, adding extra 100us delay at the end of
> wm_gmii_mdic_{read,write}reg() on PCH2. Same as FreeBSD and linux.
>
>   Reported by David Brownlee a few days ago and also reported by jmcneill
> a half year ago. Tested with my own Thinkpad X220.
>
> XXX pullup-[78]
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.591 -r1.592 src/sys/dev/pci/if_wm.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.


--
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)