Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/external/bsd/drm2/dist/drm/i915



On 21.09.2018 14:22, Christos Zoulas wrote:
> In article <20180921114916.D5B8CFA84%cvs.NetBSD.org@localhost>,
> Kamil Rytarowski <source-changes-d%NetBSD.org@localhost> wrote:
>> -=-=-=-=-=-
>>
>> Module Name:	src
>> Committed By:	kamil
>> Date:		Fri Sep 21 11:49:16 UTC 2018
>>
>> Modified Files:
>> 	src/sys/external/bsd/drm2/dist/drm/i915: i915_dma.c
>>
>> Log Message:
>> Avoid stack protector violation
>>
>> 'const int' is not a real constant in C and it cannot be used to define an
>> array with a number of elements, as it's turned into a variable length
>> array.
> 
> Typically we change the const ints into #defines instead of copying the value
> of the constant.
> 
> christos
> 

I know, but in this case the symbol name (preprocessor symbol) was
available in other functions in the same file. I've decided that it will
be simpler to just change 1 line of code.

Attachment: signature.asc
Description: OpenPGP digital signature



Home | Main Index | Thread Index | Old Index