Re: CVS commit: src/usr.sbin/npf/npfctl

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 01/09/2018 à 18:28, Mindaugas Rasiukevicius a écrit :
> Module Name:	src
> Committed By:	rmind
> Date:		Sat Sep  1 16:28:57 UTC 2018
>
> Modified Files:
> 	src/usr.sbin/npf/npfctl: npf.conf.5
>
> Log Message:
> npf.conf(5): fix some of the previous incorrect or inaccurate changes.
> The TCP flags option is not only for the stateful tracking.  Dynamic NAT
> implies NAPT; algorithms, at least for now, are for static NAT mappings.
> Mention that ALG ICMP is also for traceroute behind NAT; also mention
> "MSS clamping" (some users might search for this term, so keeping the
> terminology is helpful).
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.70 -r1.71 src/usr.sbin/npf/npfctl/npf.conf.5
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

Indeed the 'flags' option was not documented in the right section, thanks
for moving it in the correct one.

I believe it would be better to change

-	The protocol keyword can additionally have ...
+	The
+	.Cd proto
+	keyword can additionally have ...

To keep things consistent. Or even "This keyword" to avoid repeating.

And the end of the sentence should maybe be "protocol-specific options such
as 'flags'", to make it clearer that you just want to talk about 'flags' in
what follows.