Re: CVS commit: src/sys/dev/pci/ixgbe

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

On 2018/07/03 13:02, SAITOH Masanobu wrote:
> Module Name:	src
> Committed By:	msaitoh
> Date:		Tue Jul  3 04:02:07 UTC 2018
>
> Modified Files:
> 	src/sys/dev/pci/ixgbe: ixgbe.c
>
> Log Message:
>   Remove nmbclusters check.

 A big problem is that the number of RX descriptor unexpectedly
decreased from 2048 to 1024 if the number of port and/or the number
of CPU is high.

> a2sdihtp4f: sysctl -a | grep ixg | grep rx_desc
> hw.ixg0.num_rx_desc = 2048
> hw.ixg1.num_rx_desc = 2048
> hw.ixg2.num_rx_desc = 2048
> hw.ixg3.num_rx_desc = 1024


> We don't use the mbuf cluster. The old code also had
> a bug that ixgbe_total_ports adds two every port and never decrement in
> the detach path. Found by hikaru@.
>
>   The code was removed in FreeBSD when it switched to use iflib and OpenBSD
> removed the code 8 years ago.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.161 -r1.162 src/sys/dev/pci/ixgbe/ixgbe.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.


--
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)