Re: CVS commit: src/sys/dev/fdt

[Jason Thorpe <thorpej%me.com@localhost>]

> On Jun 20, 2018, at 2:06 AM, Jared McNeill <jmcneill%invisible.ca@localhost> wrote:
> 
> Not a fan of this, some of these paths can get fairly long (boot the VEXPRESS_A15 kernel to see for yourself) and the path is only really useful if you are debugging something.

Sigh.

> If you want to see the debugging information we already have a way to do that with boot -x. You can also inspect the whole tree at runtime with ofctl(8).

ofctl(8) is pretty useless for this purpose because it doesn't show you which driver instance has attached to a given device tree node.  As for passing generic boot args, it's not obvious how one does that on the RPI (and I don't even see the hook that processes the generic boot args bcm283x_platform).


> 
> 
> On Wed, 20 Jun 2018, Jason R Thorpe wrote:
> 
>> Module Name:	src
>> Committed By:	thorpej
>> Date:		Wed Jun 20 05:59:18 UTC 2018
>> 
>> Modified Files:
>> 	src/sys/dev/fdt: fdtbus.c
>> 
>> Log Message:
>> In fdtbus_print(), aprint_normal the path to the device (rather than
>> aprint_debug).  This info is every bit as useful as, say, PCI device
>> locations.
>> 
>> 
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.17 -r1.18 src/sys/dev/fdt/fdtbus.c
>> 
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.
>> 
>> 

-- thorpej