Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/gzip

On 12.06.2018 15:52, Joerg Sonnenberger wrote:
> On Tue, Jun 12, 2018 at 02:35:40PM +0200, Kamil Rytarowski wrote:
>> On 12.06.2018 14:24, Joerg Sonnenberger wrote:
>>> That's missing the point. A short description of why the specific
>>> undefined behavior is seen is useful. Pasting random program output is
>>> not.
>>> Joerg
>> Random program output might not be useful, but the one containing
>> runtime message is.. and it was 1-liner + 1 line how to invoke it and 1
>> line of runtime error. I have more to come an I will keep documenting
>> the runtime error messages.
> Are you trying hard to be obnoxious? The only useful part that you
> quoted is the runtime error itself. The rest is either noise or doesn't
> help with reproduction since it depends on external input. Nothing in
> the commit message contains a real analysis of why this "reproducer"
> triggers the problem. As such, it is pointless noise and shouldn't be
> preserved for eternity.
> Joerg

I will try to meet the expectations in commit messages for *San fixes.

I will try to also dig down why some programs needs in bit mask the sign
bit in unsigned integer instead of quickly swapping the type to unsigned.

There are just many reports so I expected to land patches quickly, just
please be aware that presenting more deep investigation in a commit
message will take longer.

Attachment: signature.asc
Description: OpenPGP digital signature

Home | Main Index | Thread Index | Old Index