Re: CVS commit: src/sys/arch/i386/stand/lib

[maya%netbsd.org@localhost]

Hi christos!

Could you explain what makes this necessary in the commit messages in
the future? It isn't very obvious that it fixes a build failure with
MKREPRO for future netbsd'ers, in case it isn't restructured.
Ideally in every commit, so it appears in a 'cvs annotate'.

Thanks.

On Mon, Jun 11, 2018 at 05:35:13PM -0400, Christos Zoulas wrote:
> Module Name:	src
> Committed By:	christos
> Date:		Mon Jun 11 21:35:13 UTC 2018
> 
> Modified Files:
> 	src/sys/arch/i386/stand/lib: Makefile.inc
> 
> Log Message:
> switch CFLAGS from using MAKEOBJDIRPREFIX to MAKEOBJDIR. This whole thing
> is disgusting, but fixing it properly. requires restructuring
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.17 -r1.18 src/sys/arch/i386/stand/lib/Makefile.inc
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 

> Modified files:
> 
> Index: src/sys/arch/i386/stand/lib/Makefile.inc
> diff -u src/sys/arch/i386/stand/lib/Makefile.inc:1.17 src/sys/arch/i386/stand/lib/Makefile.inc:1.18
> --- src/sys/arch/i386/stand/lib/Makefile.inc:1.17	Sat May 26 21:14:50 2018
> +++ src/sys/arch/i386/stand/lib/Makefile.inc	Mon Jun 11 17:35:13 2018
> @@ -1,4 +1,4 @@
> -#	$NetBSD: Makefile.inc,v 1.17 2018/05/27 01:14:50 christos Exp $
> +#	$NetBSD: Makefile.inc,v 1.18 2018/06/11 21:35:13 christos Exp $
>  #
>  #	Configuration variables (default values are below):
>  #
> @@ -24,7 +24,7 @@ CWARNFLAGS.clang+=	-Wno-tautological-com
>  I386MAKE= \
>  	cd ${I386DIR} && MAKEOBJDIRPREFIX= && unset MAKEOBJDIRPREFIX && \
>  	    MAKEOBJDIR=${I386DST} ${MAKE} \
> -	    CC=${CC:q} CFLAGS=${CFLAGS:q} \
> +	    CC=${CC:q} CFLAGS=${CFLAGS:S/MAKEOBJDIRPREFIX/MAKEOBJDIR/:q} \
>  	    AS=${AS:q} AFLAGS=${AFLAGS:q} \
>  	    LD=${LD:q} STRIP=${STRIP:q} \
>  	    MACHINE=${MACHINE} MACHINE_ARCH=${MACHINE_ARCH:q} \
>