Re: CVS commit: src/sys/sys

[Michael van Elst <mlelstv%serpens.de@localhost>]

On Tue, Apr 17, 2018 at 05:45:13PM +0200, Kamil Rytarowski wrote:
> On 04.03.2018 08:13, Michael van Elst wrote:
> > Module Name:	src
> > Committed By:	mlelstv
> > Date:		Sun Mar  4 07:13:11 UTC 2018
> > 
> > Modified Files:
> > 	src/sys/sys: device.h
> > 
> > Log Message:
> > Expose device structures to _KMEMUSER
> > 
> > 
> 
> This broke building device.h with _KMEMUSER.
> 
> > @@ -81,7 +81,7 @@
> >  #include <sys/evcnt.h>
> >  #include <sys/queue.h>
> >  
> > -#ifdef _KERNEL
> > +#if defined(_KERNEL) || defined(_KMEMUSER)
> >  #include <sys/mutex.h>
> >  #include <sys/condvar.h>
> >  #include <sys/pmf.h>
> 
> The sys/pmf.h header is not accessible from userland.

True.

What program includes device.h as _KMEMUSER but crash(8) ? There
shouldn't be any.

crash helps itself by including system headers, but that's probably
not a good recipe for everyone.



Greetings,
-- 
                                Michael van Elst
Internet: mlelstv%serpens.de@localhost
                                "A potential Snark may lurk in every tree."