On Sun, 15 Apr 2018, Christos Zoulas wrote:
In article <Pine.NEB.4.64.1804160545130.11133%speedy.whooppee.com@localhost>, Paul Goyette <paul%whooppee.com@localhost> wrote:On Mon, 16 Apr 2018, matthew green wrote:maya%netbsd.org@localhost writes:__BEGIN_DECLS? was that accessible from userland?__BEGIN_DECLS in netbsd is entirely for userland -- it is an really for C++ and we don't do C++ in the kernel (please ignore the libunwind behind the curtain :-).I'm failing to parse... Should I use __BEGIN_DECLS ... __END_DECLS here? Or not? (It looks like the code on HEAD does use these macros...) The functions being declared will _not_ be used from userland.They work either way and since the kernel does not use c++ they expand to nothing.
OK.Since your related changes on -current _do_ include the macros, I'll just add them to my code to reduce the diffs.
+------------------+--------------------------+----------------------------+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired) | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com | | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org | +------------------+--------------------------+----------------------------+