Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/kern



Christos Zoulas wrote:
> Module Name:	src
> Committed By:	christos
> Date:		Sun Apr  1 19:29:43 UTC 2018
> 
> Modified Files:
> 	src/sys/kern: subr_prf.c
> 
> Log Message:
> Add the ability to prepend a timestamp [ sec.nsec] relative to boottime
> in kernel messages if KLOG_TIMESTAMP is enabled.
> 

> +	n = snprintf(buf, sizeof(buf), "[% 9jd.%.9ld] ",
> +	    (intptr_t)ts.tv_sec, ts.tv_nsec);

Taking more than a quarter of 80-char wide terminal for a timestamp
is a bit too much, IMO. Do we really need 9 characters to print
seconds? It starts from a single digit on boot and it can increase
to 2-3 digits while it's still booting but rarely more than that.
Three digits should be enough for nice looking dmesg.boot. As a
compromise, can we settle with "% 4jd" for the seconds part?

-- 
Alex


Home | Main Index | Thread Index | Old Index