Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: [pgoyette-compat] src/sys



On Wed, 7 Mar 2018, matthew green wrote:

"Paul Goyette" writes:
Module Name:	src
Committed By:	pgoyette
Date:		Tue Mar  6 10:37:42 UTC 2018

Modified Files:
	src/sys/compat/common [pgoyette-compat]: compat_util.c files.common
	src/sys/kern [pgoyette-compat]: exec_elf.c files.kern

Log Message:
Move necessary routines out of compat_util.c and into exec_elf.c

Once again, compat_util.c is only for modules, so move it back into
compat/common/files.common and out of kern/files.kern

i don't think this is right.

exec_elf.c is compiled twice and you'll have duplicate symbols.
since they don't need to be different, i suspect another file
that is part of exec_elf{32|64} might be useful.

ie, doing this with ELFNAME() to fix duplicate symbols seems
wrong.

Yeah, this is on my list of things to fix. I plan to create an elf_emul_subr.[ch] or similar for these two functions.

Thanks for watching, and thanks for the heads-up



+------------------+--------------------------+----------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+------------------+--------------------------+----------------------------+


Home | Main Index | Thread Index | Old Index