Re: CVS commit: src/sys/arch/macppc/stand/bootxx

[Valery Ushakov <uwe%stderr.spb.ru@localhost>]

On Sat, Mar 03, 2018 at 03:44:57 +0000, Sevan Janiyan wrote:

> Like so?
> 
> 
> Index: sys/arch/macppc/stand/bootxx/Makefile
> ===================================================================
> RCS file: /cvsroot/src/sys/arch/macppc/stand/bootxx/Makefile,v
> retrieving revision 1.18
> diff -u -p -r1.18 Makefile
> --- sys/arch/macppc/stand/bootxx/Makefile       2 Mar 2018 23:15:25
> -0000       1.18
> +++ sys/arch/macppc/stand/bootxx/Makefile       3 Mar 2018 03:22:09 -0000
> @@ -23,6 +23,11 @@ CLEANFILES+= ${PROG}.sym
> 
>  ${PROG}: ${OBJS}
>         ${_MKTARGET_LINK}
> +.if ${HAVE_GCC:U0} > 0
> +       ${LD} -o ${.TARGET}.sym ${LINKFLAGS} ${OBJS}
> ${DESTDIR}/usr/lib/libgcc.a
> +.else
> +       ${LD} -o ${.TARGET}.sym ${LINKFLAGS} ${OBJS}
> +.endif
>         ${LD} -o ${.TARGET}.sym ${LINKFLAGS} ${OBJS}
>         ${OBJCOPY} -O binary ${.TARGET}.sym ${.TARGET}

Please, don't duplicate that line like that, variables were invented
for a reason... LDADD is probably the right one to use here.

BTW, we already have HAVE_LIBGCC and LIBGCC -that defaults exactly to
${DESTDIR}/usr/lib/libgcc.a (NB: you need to grep enough too to find
it (LIB\$ in bsd.prog.mk).

-uwe