Re: CVS commit: src/sys/arch/macppc/stand/bootxx

[Sevan Janiyan <sevan%NetBSD.org@localhost>]

On 03/02/18 23:22, Valery Ushakov wrote:
> That was introduced rather recently:
> 
>   revision 1.17
>   date: 2017-07-16 02:26:46 +0300;  author: christos;
>   branches:  1.17.2;
>   Avoid missing _restgpr_30_x

I did see that but thought that we'd had a toolchain update since then.
grepping the source, the only place I see a reference to it is in
external/gpl3/gcc/dist/libgcc/config/rs6000/crtresxgpr.S:HIDDEN_FUNC(_restgpr_30_x)
    lwz     30,-8(11)
external/gpl3/gcc/dist/libgcc/config/rs6000/crtresxgpr.S:FUNC_END(_restgpr_30_x)
external/gpl3/gcc.old/dist/libgcc/config/rs6000/crtresxgpr.S:HIDDEN_FUNC(_restgpr_30_x)
lwz     30,-8(11)
external/gpl3/gcc.old/dist/libgcc/config/rs6000/crtresxgpr.S:FUNC_END(_restgpr_30_x)

> I wonder if this might be dependendent on compiler options &c (e.g. on
> sh4 gcc will emit calls to some libgcc functions only for some
> optimization settings).

for my release build with GCC, I just did ./build.sh -m macppc release
for the LLVM build I did
./build.sh -V MKLLVM=yes -V HAVE_LLVM=yes -V MKGCC=no -m macppc release

I'd actually built the LLVM release using the following patch but opted
to remove the reference to libgcc.a when the default build passed on the
basis that I'd wait for the daily releng builds to see.

Index: sys/arch/macppc/stand/bootxx/Makefile
===================================================================
RCS file: /cvsroot/src/sys/arch/macppc/stand/bootxx/Makefile,v
retrieving revision 1.17
diff -u -p -r1.17 Makefile
--- sys/arch/macppc/stand/bootxx/Makefile       15 Jul 2017 23:26:46
-0000      1.17
+++ sys/arch/macppc/stand/bootxx/Makefile       2 Mar 2018 20:13:38 -0000
@@ -23,7 +23,7 @@ CLEANFILES+=  ${PROG}.sym

 ${PROG}: ${OBJS}
        ${_MKTARGET_LINK}
-       ${LD} -o ${.TARGET}.sym ${LINKFLAGS} ${OBJS}
${DESTDIR}/usr/lib/libgcc.a
+       ${LD} -o ${.TARGET}.sym ${LINKFLAGS} ${OBJS} ${${ACTIVE_CC} ==
"gcc":? ${DESTDIR}/usr/lib/libgcc.a :}
        ${OBJCOPY} -O binary ${.TARGET}.sym ${.TARGET}

 .include <bsd.klinks.mk>